Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destination S3-V2: Rc 9 with bug fixes #51048

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Destination S3-V2: Rc 9 with bug fixes #51048

wants to merge 2 commits into from
+10 −5

Conversation

johnny-schmidt
Copy link
Contributor

What

Next rc with bugfixes for

  • path variable in bucket prefix
  • sync hanging on missing state

@johnny-schmidt johnny-schmidt requested a review from a team as a code owner January 10, 2025 21:57
@vercel Vercel
Copy link

vercel bot commented Jan 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
airbyte-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 11, 2025 1:01am

@octavia-squidington-iii octavia-squidington-iii added area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3 labels Jan 10, 2025
@johnny-schmidt johnny-schmidt mentioned this pull request Jan 10, 2025
Merged
@johnny-schmidt johnny-schmidt requested a review from a team as a code owner January 11, 2025 00:55
tryangul
tryangul reviewed Jan 11, 2025
View reviewed changes
airbyte-integrations/connectors/destination-s3/gradle.properties
@@ -1,2 +1,2 @@
testExecutionConcurrency=-1
JunitMethodExecutionTimeout=35 m
JunitMethodExecutionTimeout=60 m
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we lower this back before we merge?

tryangul
tryangul approved these changes Jan 11, 2025
View reviewed changes
Copy link
Contributor

@tryangul tryangul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, assuming we lower the junit timeouts. Can fast follow PR in a pinch imho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tryangul tryangul tryangul approved these changes

Assignees
No one assigned
Labels
area/connectors Connector related issues area/documentation Improvements or additions to documentation connectors/destination/s3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnny-schmidt @tryangul @octavia-squidington-iii